Dan Kenigsberg has posted comments on this change. Change subject: add VdsmConfig.py for support writing comment to config file ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) could you describe the deep motivation for this patch? is it plain cleanup, or do you have another goal here? .................................................... File vdsm/config.py.in Line 254: if len(sys.argv) < 2: could you explain the motivation for this? do you plan to write files other than vdsm.conf? .................................................... File vdsm/VdsmConfig.py Line 36: self._commentDict[key] = comment I think you'd want to support the same key in two different sections. -- To view, visit http://gerrit.ovirt.org/4826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06d8d23e1d1f12b880ae71e2c978efcfece8001a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
