Wenyi Gao has posted comments on this change. Change subject: Remove the effect of other parameters on configure_sysctl ......................................................................
Patch Set 2: Just be for clear for previous comments When vdsm first set sysctl.conf, it will run 'sysctl -q -p /etc/sysctl.conf', but if the bridge on OS is not set up, the sysctl will cannot return 0, which will cause the following error: $ sudo /lib/systemd/systemd-vdsmd start WARNING: no socket to connect to vdsm: libvirt already configured for vdsm [ OK ] Configuring sysctl for vdsm... /proc/sys/net/bridge/bridge-nf-call-ip6tables: No such file or directory /proc/sys/net/bridge/bridge-nf-call-iptables: No such file or directory /proc/sys/net/bridge/bridge-nf-call-arptables: No such file or directory vdsm: failed to reconfigure libvirt [FAILED] -- To view, visit http://gerrit.ovirt.org/4865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d9f917a4abfb6952fb9fdd6a9c0e12751ecd061 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao <we...@linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com> Gerrit-Reviewer: Wenyi Gao <we...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches