Dan Kenigsberg has posted comments on this change.
Change subject: BZ#822158: fail to join host to cluster
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Thanks Douglas, that's highly important. But please verify that the dsaversion
being produced is legible to Engine.
....................................................
Commit Message
Line 9: Do not use @PACKAGE_VERSION@ and @PACKAGE_RELEASE@
Please mention dsaversion and explain why - Engine cannot handle anything bug
X.Y version/release.
....................................................
File vdsm.spec.in
Line 320: sed -i 's/^software_version =.*/software_version =
"%{version}"/;s/software_revision =.*/software_revision = "'"$baserelease"'"/'
vdsm/dsaversion.py
better break this long line.
but more importantly, we cannot take %{version} verbatim, as it has 3 parts,
and Engine handles only two. Please make sure software_version=X.Y
--
To view, visit http://gerrit.ovirt.org/4910
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0dbe689482913ed46e65ada327d387d6305916a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
