Ayal Baron has posted comments on this change. Change subject: Reuse the stored pool host id on reconstructMaster ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/storage/sp.py Line 203: def _acquireHostId(self, sdUUID, isValid): Why is this function here? it is never used? Line 496: def _acquireTemporaryClusterLock(self, msdUUID, safeLease, hostId=None): Reading this now it appears to me as though this function is misnamed as it doesn't make the cluster lock temporary at all, it is just *used* this way by the calling function. Also, since we cannot reliably determine the host id I'm starting to think that the annoyance here outgrows the benefit and maybe we should just get rid of this 'protection' altogether, or at least get rid of the call in create and just use this in reconstructMaster (and then inline the funcion as I have no idea what to name it :) -- To view, visit http://gerrit.ovirt.org/4965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44ff6d04220032ac1f6bd0a7819132103050b516 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
