Dan Kenigsberg has posted comments on this change.
Change subject: Replace the username for SASL authenticating by constant
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
thanks - but let's be more complete.
....................................................
File vdsm/libvirtconnection.py
Line 106:
'libvirt_password').readline().rstrip("\n")
come to think of this
constants.P_VDSM_KEYS + 'libvirt_password'
is mentioned in your tool.passwd for the second time. better define another
constant for the file location, too.
--
To view, visit http://gerrit.ovirt.org/5037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic73829bf7e1b10d72203a607680221c0ef0a889f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <li...@linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
