Wenyi Gao has posted comments on this change. Change subject: Make safer to get vdsm section version in configuration files ......................................................................
Patch Set 1: No score Hi Douglas, thanks for your comments. Currently, the version number is 4.9.6. We only search the number "4.9.6" to decide if the vdsm section is in configuration files. If configuration files happen to have the same number, we will get something wrong. In the feature, the version number may be 6.0 or something else that is a simple number. I think it is always a potential problem. -- To view, visit http://gerrit.ovirt.org/5051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I947522f6a819ecd4ea62747b42d79e11b65543af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Wenyi Gao <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
