Dan Kenigsberg has posted comments on this change. Change subject: tests: add testcase for configNetwork ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) thanks for adding a unit test! .................................................... File tests/configNetworkTests.py Line 30: nics_init = ['eth2', 'eth0', 'eth1', 'em0', 'em2', 'em1'] there are much more "hairy" examples, such as ["p331", "p33p1"] from the code. Please add more pairs of init/expected. p.s. they should be tuples, and probably a dictionary mapping _init to its expected tuple. Line 36: invalidBrName = ['-abc', 'abcdefghijklmnop', 'a:b', 'a.b'] list -> tuple, as we do not need modify invalidBrName. -- To view, visit http://gerrit.ovirt.org/5351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3124114471f41b44fb8c19bf2e3cdcf95bc9364 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
