Mark Wu has posted comments on this change. Change subject: vdsmd: Don't keep the temporary file generated by configuring libvirt ......................................................................
Patch Set 1: I have filed a sed bug and cc'ed to you :) I think it's better to use augtool to manipulate libvirt configuration than sed. augtool should be able to cover the use case of configuring on install and removing configuration by vdsm on uninstall. What's your opinion bout it? If you think it's good, I will submit a patch later. Thanks -- To view, visit http://gerrit.ovirt.org/4864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5c0fe8b86c4fa82bb89d581f594b0dfb9aae425 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Michael Burns <mbu...@redhat.com> Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
