Wenyi Gao has posted comments on this change.
Change subject: Move vdsmd.init to vdsm-tool
......................................................................
Patch Set 4: (9 inline comments)
Dan, thanks for your suggestion. I will divide it into some small patches.
....................................................
File vdsm-tool/vdsmd.py
Line 133: def _print_success_msg(msg):
Dan, the function don't print the output of 'success'. It just behaves like
other initial boot script and pints '[ OK ]' as following:
configure ....... [ OK ]
Line 366: return False
Yes, good suggestion.
Line 427: return 6
Yes, a constant is better.
Line 475: ssl == 'true'):
Yes, good.
Line 547: f.write('%s\n' % VDSM_SYSCTL_VER)
Yes, it makes sense.
Line 562: Stop libvirt SysV service if we intend to configure upstart
Yes.
Line 565: if(_upstart_libvirt()):
Yes.
Line 596: @vdsm_tool_expose('vdsm-start')
Yes, good point, I will make some smaller functions exposed.
Line 749: _reconfigure(False)
Yes, looks very simple.
--
To view, visit http://gerrit.ovirt.org/4738
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52db67207532ac7ded51cdd8c5dc388e85629104
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Wenyi Gao <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
