Dan Kenigsberg has submitted this change and it was merged. Change subject: Move actual VM creation function to clientIF.py ......................................................................
Move actual VM creation function to clientIF.py To avoid using API in clientIF.py, we move the VM creation function to clientIF.py. It should be safe to skip the VM parameters validation in the VM.create() API for recovering exsiting VMs. If this patch is accepted, we can add a singleton interface for clientIF which can be used for API.py. Otherwise, it will cause circular importing. Change-Id: I38644263e4b4c3fe836a60405b251768db0a471c Signed-off-by: Mark Wu <[email protected]> --- M vdsm/API.py M vdsm/clientIF.py 2 files changed, 27 insertions(+), 25 deletions(-) Approvals: Mark Wu: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38644263e4b4c3fe836a60405b251768db0a471c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
