Dan Kenigsberg has posted comments on this change. Change subject: make storage/securable.py PEP8 clean ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/storage/securable.py Line 17: # MA 02110-1301 USA I prefer to keep it on the same line - that's what we do in most boilerplates. Line 40: and not getattr(val, SECURE_FIELD)): You may move the "and" a line up. -- To view, visit http://gerrit.ovirt.org/5416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic65b657112d55c4c68e7056d0a6f478221f92891 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Bing Bu Cao <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Wenchao Xia <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
