Xu He Jie has posted comments on this change.

Change subject: add configure variable vdsmcoredumpdir for /var/log/core
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File vdsm/sos/vdsm.py.in
Line 82:         self.collectExtOutput("/bin/ls -l " + 
constants.P_VDSM_CORE_DUMP)
no, this is rebase failure, I removed constants from previous patch.

done for use @MACRO@

....................................................
File vdsm/utils.py
Line 203:     MONITORED_PATHS = ['/tmp', '/var/log', 
constants.P_VDSM_CORE_DUMP, constants.P_VDSM_RUN]
I move MONITORED_PATHS to constants in later patch.

--
To view, visit http://gerrit.ovirt.org/5150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94ac220078f8a00fbdd8aba6125bedda44a77d15
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to