Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: do not dd into /dev/null ......................................................................
tests: do not dd into /dev/null Few of our tests run /bin/dd with of=/dev/null. Occasionally, dd calls fsync(2) on its destination file, which is (for some reason) unsupported by /dev/null. We are left with false-negative test results such as http://jenkins.ovirt.org/job/vdsm_unit_tests/215/testReport/junit/miscTests/DdWatchCopy/testStop/ which tarnishes our reputation. Let's dd into a temporary file instead. Change-Id: I93a91a0cab852a28c1f3674d44ea3e0c750f62f2 Signed-off-by: Dan Kenigsberg <[email protected]> --- M tests/miscTests.py 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Gal Hammer: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved Igor Lvovsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93a91a0cab852a28c1f3674d44ea3e0c750f62f2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
