Dan Kenigsberg has posted comments on this change.

Change subject: Move option 'save_image_format' to qemu.conf
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 10: so move it to qemu.conf.
Ouch. This is pretty painful. Thanks for fixing.

Could you check how this change would affect our users with images 
already-saved with gzip compression? Would libvirt be able to restore them? (if 
not, it makes a nice libvirt feature request).

....................................................
File vdsm/vdsmd.init.in
Line 276:     local by_vdsm_vers="4.9.7"
I think 4.10 would be more informative

--
To view, visit http://gerrit.ovirt.org/5928
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55d3e33783071cacbc71a31c5c46083e99fe65d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to