Igor Lvovsky has posted comments on this change. Change subject: BZ#834205-related: report ipaddr of bridgeless networks ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) Only minor comment inside. Don't forget to backport it to downstream without ethtools .................................................... File vdsm/netinfo.py Line 245: 'stp': bridge_stp_state(netname), I think it should be more consistent. Please use 'netname' or 'devname' for all cases: ports, bridge_stp_state and getIfaceCfg -- To view, visit http://gerrit.ovirt.org/6035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c03a30c31f68f86a195b8d47d3134fc43dca870 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
