Alon Bar-Lev has posted comments on this change.
Change subject: build: use consistent python path
......................................................................
Patch Set 2:
Hello Dan,
First, I did not suggest to modify all python script... so we can relax... :)
The difference between the #!/usr/bin/python and direct execution of python is
significant.
The #!/usr/bin/python signature may be converted to any other valid signature
using a simple process. In distribution such as Gentoo the package management
is doing that automatically using the following statement (modify all shbangs
to use python release 2):
---
python_convert_shebangs -r 2 "${ED}"
---
Other distribution may have similar methods if they support side-by-side python
versions.
However, executing python directly is something that cannot be converted
automatically, we need extra cation when manually executing python and not
executing a script with the #! signature.
If we can make anything executable and remove the direct python usage it will
also provide a solution, this also may be done later.
As I wrote there are only two left overs which executes python directly:
---
./vdsm/addNetwork
./vdsm/delNetwork
---
These both uses hardcoded python (/usr/bin/python -m), which might be replaced
with @PYTHON@ as in any other script, or call configNetwork.py with
#!/usr/bin/python signature.
Alon.
--
To view, visit http://gerrit.ovirt.org/6049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac659a50019f42eb72fc35c2f8a1f7c0fbb2db50
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
