Dan Kenigsberg has posted comments on this change. Change subject: Handle bridgeless networks too in getNetworksAndVlansForBonding ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/netinfo.py Line 335: if bonding == netdict['interface']: you are duplicating code: how about defining a helper function to split iface.vlan to its components? -- To view, visit http://gerrit.ovirt.org/6143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I615b6c7afeb46ac9928c2ab4e27a723658b58631 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
