Zhou Zheng Sheng has posted comments on this change.
Change subject: Suppress generating .py{c,o} files when 'make check'
......................................................................
Patch Set 4:
The purpose of this patch is to avoid false positives in 'make check'.
We sometimes write ad-hoc Python scripts to test the code in the source tree
and throw them away. In this case, some .pyc files will be generated. So to
clean all .pyc files, I submit patch set 2. However, maintaining the lists in
"Makefile.am"s is error prone.
So I submit patch set 3. Supposing we only care about the .py files used in
unit tests. It traces the .pyc files generated in unit tests, then clean them.
The method is a bit complicated but it's automatic.
Patch set 4 just prevent Python from generating .pyc files. This method is
simple. However, in case someone trigger Python to generate a .pyc file in an
ad-hoc test script, 'make check' will still give false positive if the
corresponding .py file is missing.
So I think "find . -name '.py[co]' | xargs rm -f" can have a chance, but it may
be an overkill.
--
To view, visit http://gerrit.ovirt.org/5934
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43ad6301a761ba53c81e505804f3301c526eab6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
