Ayal Baron has posted comments on this change. Change subject: Remove the unused nocache option ......................................................................
Patch Set 17: Looks good to me, approved (3 inline comments) .................................................... File vdsm/storage/blockVolume.py Line 685: return out looks like this should be 'break' and not 'return' ? Line 695: def setMetadata(self, metaarr, metaid=None): looks like metaid is never used either? .................................................... File vdsm/storage/fileVolume.py Line 382: return out looks like this should be 'break' and not 'return' -- To view, visit http://gerrit.ovirt.org/3747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I799991662f8c4c717112f783e8f5d2ce3fd13f9c Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
