Adam Litke has posted comments on this change. Change subject: vdsm_api: Add schema and html doc generator ......................................................................
Patch Set 1: (2 inline comments) Thanks for your review Saggi... .................................................... File vdsm_api/ordereddict.py Line 25: class OrderedDict(dict, DictMixin): Absolutely nothing. Thanks for catching it! The next iteration will remove this file. .................................................... File vdsm_api/vdsmapi-schema.json Line 1574: # @XXX: A dictionary of @StorageDomainStats indexed by Storage Domain @UUID The typing is complete. The problem being pointed out by the XXX is that the keys in the StorageDomainStatsMap are merged directly into the root return dict (along with doneCode). To conform with the rest of the calls the stats should be hung off of a 'stats' key or something. -- To view, visit http://gerrit.ovirt.org/6343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I703703ba212b7560d1054f32a86ad083ee88c6c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
