Federico Simoncelli has posted comments on this change.
Change subject: Change exception thrown by validateQemuReadable
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/storage/fileUtils.py
Line 38: import storage_exception as se
Let's try to get rid of this dependency.
Line 103: raise se.StorageServerAccessPermissionError(targetPath)
Could you get rid of this too?
Line 154: raise se.MiscDirCleanupFailure("%s %s" % (dirPath,
cleanupdir_errors))
Could you get rid of this too?
--
To view, visit http://gerrit.ovirt.org/6463
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c6a4fded368e89f057d244665be0e37d71f2d08
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
