Ayal Baron has posted comments on this change. Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 3: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/libvirtvm.py Line 1794: and type(e) == libvirt.libvirtError): can't we check the specific error in case quiesce failed? Line 1813: break how can management differentiate between a snapshot that was taken with quiesce and one that was not? -- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
