Dan Kenigsberg has posted comments on this change.
Change subject: test: skip configNetworkTests.py::testPersistentBackup if not
root or vdsm user absent
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File tests/configNetworkTests.py
Line 112: raise SkipTest("This test must be run as root")
actually, I tried hard to monkey patch os.chown, so root is not needed.
Line 114: pwd.getpwnam('vdsm')
that's acceptable with the current state of the code, but I actually think that
we'd be better off ditching these chown's from vdsm proper. Why do we even need
them?
--
To view, visit http://gerrit.ovirt.org/6492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5e3a2ce6616f6313363079ad24fd62f86504071
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
