Dan Kenigsberg has posted comments on this change. Change subject: BZ#831528, BZ#834008, BZ#829037 - Fix validation for inter-networks compatibility ......................................................................
Patch Set 3: I would prefer that you didn't submit this (4 inline comments) few comments .................................................... File vdsm/configNetwork.py Line 506: def _verifyNetworkCompatibility(ni, vlan, iface, bridged): we tend to use "validate" here. let's continue. _validateInterNetworkCompatibility ? Line 515: def _checkCompatibility(ifaces): _validateNoNativeNet() # validate that none of the ifaces is a non-VLANed network over our iface. Line 522: ifaces_bridgeless = ni.getBridgelessNetworksAndVlansForIface(iface) this is going to be used twice - second usage would be null. copy to tuple() to avoid this. Line 616: (nics, vlansForNic)) to satisfy Tony's concern: please validate that the nic is not used directly by any network. -- To view, visit http://gerrit.ovirt.org/6384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1de66dea8cf73ecdde8e6651d4a2209be120a707 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
