Dan Kenigsberg has posted comments on this change. Change subject: BZ#837836 Change tpgt variable to identically None ......................................................................
Patch Set 2: I would prefer that you didn't submit this I'd be happier if the commit message had include a description of what is removed, why, and why we're not breaking an API by this. I found a joyous comment by Saggi in the cited bug, not I am personally content. Yet the commit message should be more descriptive - maybe you can rephrase Saggi's text to a language that we mortals understand. """ This is not a but, someone sent a string in the portal field (which is actually tpgt) Engine internally never does this and sending this is wrong anyway. The real issue is that the parameter name has been confusing all this time until I decided to fix it. This is not a bug, the bug was that it worked in the first place. """ -- To view, visit http://gerrit.ovirt.org/6367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f368ce449e9cd51a06398e54d9b5ffbec20e842 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
