Wenyi Gao has posted comments on this change. Change subject: Move validate_libvirt_certs to vdsm-tool ......................................................................
Patch Set 2: (4 inline comments) Many thanks for reviewing the patch. .................................................... File vdsm/constants.py.in Line 117: EXT_OPENSSL = '@OPENSSL_PATH@' Yes, "openssl" is used in the function "validate_libvirt_certs" .................................................... File vdsm-tool/base.py Line 25: def exec_command(argv): Yes, we can replace it with vdsm.utils.execCmd. .................................................... File vdsm-tool/validate_libvirt_certs.py Line 51: exec_command([EX_UNPERSIST, CACERT_PATH, '1']) Ok, I will add some explaination and comments for this. Line 53: shutil.copy('%s/file' % BASE_PATH, CACERT_PATH) Sorry for this mistake. -- To view, visit http://gerrit.ovirt.org/5961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b6504ae2e3c8ffa0c33d7ba22a7c16597a51945 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao <we...@linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Wenyi Gao <we...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches