Dan Kenigsberg has posted comments on this change.
Change subject: MOM Integration
......................................................................
Patch Set 15: Looks good to me, but someone else must approve
(2 inline comments)
this patch has waited long enough.
....................................................
File vdsm/ksm.py
Line 109: KSM_PARAMS = {'run': 3, 'sleep_millisecs': 0x100000000,
I still do not think KSM_PARAMS should be public.
Line 114: if k not in KSM_PARAMS.keys():
use iterkeys() when there is no reason to create a new list.
--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
