Dan Kenigsberg has posted comments on this change.

Change subject: Change source of CPU sockets/cores to libvirt and add 
cpuThreads.
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File vdsm/caps.py
Line 91:         nodeinfo = c.getInfo()
please read

 commit ac9dd4a676f21b5e3ca6dbe0526f2a6709072beb
 Author: Jiri Denemark <[email protected]>

I'm not sure that nodeinfo is to be relied upon (even though it is kinda-ok for 
your use case)

--
To view, visit http://gerrit.ovirt.org/5481
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1619e3d9e042bc801c988f099d3b84922f4e03d3
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <[email protected]>
Gerrit-Reviewer: Amador Pahim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to