Zhou Zheng Sheng has posted comments on this change.
Change subject: rename xml.dom.minidom.parseString to _domParseStr in libvirtvm
......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve
(1 inline comment)
Run through autobuild.sh, but I disable two tests, testAddNetworkValidation and
test_mkFloppyFs. These two tests will fail on my machine when I checkout the
latest master and build.
Examine all the changes using pydiff. pydiff says all the changes is about the
short name. So we can know no other things are changed.
The detailed pydiff report:
pydiff libvirtvmo.py libvirtvm.py
12 difference(s)
first file: libvirtvmo.py
second file: libvirtvm.py
((24, None),
(24, From('xml.dom.minidom', [('parseString', '_domParseStr')], 0)))
((1928,
"Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"),
(1929, "Name('_domParseStr')"))
((1944,
"Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"),
(1945, "Name('_domParseStr')"))
((2000,
"Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"),
(2001, "Name('_domParseStr')"))
((2132,
"Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"),
(2133, "Name('_domParseStr')"))
((2157,
"Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"),
(2158, "Name('_domParseStr')"))
((2204,
"Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"),
(2205, "Name('_domParseStr')"))
((2229,
"Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"),
(2230, "Name('_domParseStr')"))
((2258,
"Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"),
(2259, "Name('_domParseStr')"))
((2287,
"Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"),
(2288, "Name('_domParseStr')"))
((2352,
"Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"),
(2353, "Name('_domParseStr')"))
((2366,
"Getattr(Getattr(Getattr(Name('xml'), 'dom'), 'minidom'), 'parseString')"),
(2367, "Name('_domParseStr')"))
....................................................
File vdsm/libvirtvm.py
Line 2290: getElementsByTagName('disk')
The .getElementsByTagName() call chain can be rewritten using XPath. Regarding
we have to write many test cases to verify a XPath patch code logic is the same
as current code, we can just live with the current version.
--
To view, visit http://gerrit.ovirt.org/6847
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e4ed0795b887c3df292eee1e2555428e1e9beae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
