Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Add create operation to qemu-img ......................................................................
Patch Set 6: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/qemuImg.py Line 114: #TBD: Escape backing file option? How? I think Popen normally escapes the arguments and betterPopen inherits from Popen. Can you elaborate what you mean here? Line 117: cmd.append(filename) Please insert an empty line between this and the next to keep it consistent. -- To view, visit http://gerrit.ovirt.org/6245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I078afcb0899792805584fc56832747d36908f18b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
