Dan Kenigsberg has posted comments on this change. Change subject: Implement RLock in betterThreading ......................................................................
Patch Set 3: (1 inline comment) I have to beg your pardon - earlier I did not see your next patch that makes the need of RLock apparent. .................................................... File vdsm/pthread.py Line 42: SIZEOF_PTHREAD_MUTEXATTR_T = 4 a matter of taste: I don't see why we should mention PTHREAD in the names of these new constants. The old classes should not mentioned it, too, but that's another story. -- To view, visit http://gerrit.ovirt.org/6832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I697b69fb24b4d741f37d9448295c8bb6a82464b9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
