Dan Kenigsberg has posted comments on this change. Change subject: Move createLibvirtNetwork and removeLibvirtNetwork to the ConfigWriter ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/configNetwork.py Line 191: def removeLibvirtNetwork(cls, network, log=True): the whole point of moving this into the class was to make it possible to store stuff in "self". I do not see why we need an intermediate stage where this is a @classmethod. Line 260: def writeConfFile(self, fileName, configuration): you know me - I don't think that moving this function around has any merit, certainly not within this patch. -- To view, visit http://gerrit.ovirt.org/6893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I672ce5fbe0c5db826d53664285ea6212f49fa50b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
