Doron Fediuck has posted comments on this change. Change subject: Replace calling setSchedulerParameters() with filling its XML description. ......................................................................
Patch Set 1: (2 inline comments) Mark, it terms of libvirt functionality, does this patch change the functionality? Also, please see inline- I'd like to make sure we do not loose a default setup for nice. .................................................... Commit Message Line 11: libvirt call on VM statup. (sorry for nit-picking) s/statup/startup/ ? I think VM start is simpler and even better .................................................... File vdsm/libvirtvm.py Line 704: if 'cpuPinning' in self.conf or 'nice' in self.conf: Mark, please correct me if I'm wrong, but in previous implementation we always had a default 'nice' (it wasn't within a conditional block), whereas in this implementation if you do not get both pinning and nice, there will be no default nice set. -- To view, visit http://gerrit.ovirt.org/6290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I211e191022f5a18fa7d97d5a8fb42e10729ddd06 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
