Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Add permutation feature to testing framework ......................................................................
Patch Set 7: (2 inline comments) I can see that's an advantage, but the format of [(name, args)] was a bit confusing to me. Maybe make it a dict so it's clear. Also some inline suggestions to make it shorter. .................................................... File tests/testrunner.py Line 40: return wrapper I think this is equal to functools.partial, thus redundant. Line 53: wrapper = _getPermutation(f, args) wrapper = functools.partial(f, *args) -- To view, visit http://gerrit.ovirt.org/6244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26871027182a151fd63c381879e72255f6161695 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
