Saggi Mizrahi has posted comments on this change. Change subject: [WIP] vdsm API and libvdsm ......................................................................
Patch Set 1: (2 inline comments) .................................................... File vdsm_api/libvdsm-base.vala Line 13: this._mtx = new Mutex(); You don't do new Mutext() It's deprecated. Mutexes are initialized on deceleration. This is the major reason for adding --target-glib=2.32 to vala flags Look at how I did it. http://gerrit.ovirt.org/#/c/6659/1/libvdsm/libvdsm-base.vala .................................................... File vdsm_api/Makefile.am Line 40: -g \ -g generates debug symbols. It shouldn't be on by defaults. -- To view, visit http://gerrit.ovirt.org/6863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c7427ea3f757135c9919fd65603495878fe3ae6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Xu He Jie <x...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
