Alon Bar-Lev has posted comments on this change.
Change subject: configNetworkTests: use context to manage monkey patches
......................................................................
Patch Set 3: (7 inline comments)
....................................................
File tests/configNetworkTests.py
Line 157:
Never done this, but I will try.
Line 163: ]):
Why?
It allows easy patching of new entries.
Line 314: # a rather ugly stubbing
Done
Line 338: (netinfo, 'NET_CONF_BACK_DIR',
os.path.join(self._tempdir, 'netback')),
Done
....................................................
File tests/monkeypatch.py
Line 40: for f in what:
Done
Line 43: func=f[2]
Done
Line 47: yield {}
This is by documentation of this package... I can drop it if you like.
--
To view, visit http://gerrit.ovirt.org/6939
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ecb4589f2edbf605e62a8963889d314c2535537
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
