Gal Hammer has posted comments on this change.
Change subject: BZ#845994 VM failed to start after file injection.
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File vdsm_hooks/fileinject/before_vm_start.py
Line 34: sys.stderr.write('fileinject: [error in inject_file]: %s\n' %
e)
I preferred not to change the function's behavior too much in one patch. The
calling code expect the inject_file function not to fail and return a boolean
value.
Line 46: try:
Done
Line 50: gfs.upload(temp.name, filepath)
Done. I've used the existing code and not too familiar with the GuestFS
library's functions.
--
To view, visit http://gerrit.ovirt.org/6956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb705a7153b1d2662a1c113bbbb5c694c568cabd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <gham...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Gal Hammer <gham...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
