Dan Kenigsberg has posted comments on this change. Change subject: Initialize the pthread RLock attribute ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/pthread.py Line 74: _libpthread.pthread_mutexattr_init(C.byref(self._attr)) I understand why it is sane to initialize attr to a non-random value. but why do we need to keep _attr as a data member? and if so, shouldn't it be added to __slots__? -- To view, visit http://gerrit.ovirt.org/6988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d71606113c8bbb17620a753f534532510d92c6a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
