Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832765 - Load backups from backup files to memory
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File vdsm/configNetwork.py
Line 320: if os.path.isfile(fpath):
how about saving us an annoying level of indentation with
if not os.path.isfile(fpath):
continue
?
Line 328: os.path.basename(fpath))]
= content
ah, sorry... I did not notice that "f" was used here...
If I did, I would not have suggested the recent change.
how about setting
basename = os.path.basename(fpath)
once?
--
To view, visit http://gerrit.ovirt.org/6967
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2003e1b0b198fd14d69cc0ed59b2e6d0d8abe36
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvov...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
