Bala.FA has posted comments on this change.

Change subject: Added glusterVolumeStatus verb
......................................................................


Patch Set 2: (6 inline comments)

....................................................
File vdsm_cli/vdsClientGluster.py
Line 198:         if len(args) == 2:
I got with meaningful argument names

....................................................
File vdsm/gluster/cli.py
Line 89:     status['name'] = tree.find('volStatus/volName').text
Done

Line 95:         value = {}
Done

Line 103:             value['status'] = 'OFFLINE'
Done

Line 128:     bricks = []
Done

Line 152:     bricks = []
Done

--
To view, visit http://gerrit.ovirt.org/6374
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8769c2da299a598ed7500c4780a3329972f4a8ac
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: Vijay Bellur <vbel...@gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to