Francesco Romani has posted comments on this change. Change subject: virt: Only filter guest agent data, only on XMLRPC ......................................................................
Patch Set 7: Code-Review-1 (2 comments) seems a bad rebase https://gerrit.ovirt.org/#/c/36949/7/tests/vmfakelib.py File tests/vmfakelib.py: Line 141: def __init__(self): Line 142: self.guestDiskMapping = {} Line 143: self.diskMappingHash = 0 Line 144: Line 145: def getGuestInfo(self, viaXMLRPC=False): should be filtered=False Line 146: return { Line 147: 'username': 'Unknown', Line 148: 'session': 'Unknown', Line 149: 'memUsage': 0, https://gerrit.ovirt.org/#/c/36949/7/vdsm/API.py File vdsm/API.py: Line 1296: self.log.error("failed to retrieve hardware info", exc_info=True) Line 1297: return errCode['hwInfoErr'] Line 1298: Line 1299: def getAllVmStats(self): Line 1300: return self._getAllVmStats() bad rebase, it seems Line 1301: Line 1302: def _getAllVmStats(self, filtered=False): Line 1303: """ Line 1304: Get statistics of all running VMs. -- To view, visit https://gerrit.ovirt.org/36949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ee2a8f1cc6784c619ce68da3cb9342b0d72cfc Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
