Nir Soffer has posted comments on this change. Change subject: hsm: Support GUID list param in GetDeviceList ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40661/3/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 2027: elif sd.storageType(storageType) == sd.type2name(sd.FCP_DOMAIN): Line 2028: typeFilter = \ Line 2029: lambda dev: multipath.devIsFCP(dev.get("devtype")) Line 2030: else: Line 2031: return devices > My change will return empty list only if the storageType is not None and no If the user provided invalid type, it makes sense to fail to the request, but this may break existing users, so I think we should be careful with it. Lets separate this change to another patch so we can discuss it later. Line 2032: Line 2033: pvs = {} Line 2034: if guids: Line 2035: for guid in guids: -- To view, visit https://gerrit.ovirt.org/40661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic173d94a132e617ae97353d38520a86bede657d7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
