Yaniv Bronhaim has submitted this change and it was merged. Change subject: Fix the CPU quota MOM policy computations ......................................................................
Fix the CPU quota MOM policy computations This changes the way we compute period and quota to what is described in the documentation: The maximum CPU load percentage is related to the total computing power the host has. Two issues are also fixed by this: - the period could get below 1000 with low enough percentage or high enough vCPU count and libvirt won't accept that - the quota number was higher than period when vCPU count was lower than the number of physical CPUs, effectively disabling the CPU limits An additional improvement in performance should be visible for VMs that do not use cpu limiting (using 100% as the limit), because the policy disables cgroups limit tracking in that case. Change-Id: Ia1f014d1b4058ef447a962cbda3336115e8610dc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1213438 Signed-off-by: Martin Sivak <[email protected]> Reviewed-on: https://gerrit.ovirt.org/39411 Reviewed-by: Adam Litke <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> Reviewed-on: https://gerrit.ovirt.org/40311 Reviewed-by: Yaniv Bronhaim <[email protected]> Continuous-Integration: Yaniv Bronhaim <[email protected]> --- M tests/Makefile.am A tests/momPolicyTests.py M vdsm.spec.in M vdsm/mom.d/04-cputune.policy 4 files changed, 174 insertions(+), 10 deletions(-) Approvals: Adam Litke: Looks good to me, but someone else must approve Martin Sivák: Verified Yaniv Bronhaim: Looks good to me, approved; Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40311 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1f014d1b4058ef447a962cbda3336115e8610dc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
