Dan Kenigsberg has posted comments on this change. Change subject: sampling: less verbose debug in _getInterfaceStats ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40424/4/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 708: if ifid not in hs0.interfaces: Line 709: continue Line 710: ifrate = hs1.interfaces[ifid].speed or 1000 Line 711: Mbps2Bps = (10 ** 6) / 8 Line 712: thisRx = (hs1.interfaces[ifid].rx - hs0.interfaces[ifid].rx) % \ I'd be happy if you add a #REQUIRED_FOR: engine < 3.6 since this whole rxRate/txRate should be deprecated. Line 713: (2 ** 32) Line 714: thisTx = (hs1.interfaces[ifid].tx - hs0.interfaces[ifid].tx) % \ Line 715: (2 ** 32) Line 716: rxRate = 100.0 * thisRx / interval / ifrate / Mbps2Bps -- To view, visit https://gerrit.ovirt.org/40424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
