Dan Kenigsberg has posted comments on this change. Change subject: migration: remove getVmStats before migration ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/39202/8/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 124 Line 125 Line 126 Line 127 Line 128 > Problem is this check is racy. I don't think the benefit outweight the prob Having the same VM running on two hosts is an end-of-the-world scenario. Knowing about it just before migration is actually very late. If the VM exists also in the destination, migrateCreate would return 'exist' error code, which would be logged only slightly later. Feng, from your experience, has this debug message ever helped you? I'd be happy to see this check gone. -- To view, visit https://gerrit.ovirt.org/39202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83ab46173d5d7e5bfd85bf00b8f86a530da5dd4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Feng Yang <yangf...@cloud-times.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
