Dan Kenigsberg has submitted this change and it was merged. Change subject: netlink: rtnl_put_link after rtnl_link_get_kernel ......................................................................
netlink: rtnl_put_link after rtnl_link_get_kernel According to netlink documentation [1] we have to decrement reference counter when we don't need link (obtained from rtnl_link_get_kernel) anymore, otherwise we cause a leak. This bug was found by John Taylor <[email protected]> [2]. Note that even before [3] was merged, _get_link() failed to call rtnl_put after yielding the result of rtnl_link_kernel(). [1] http://www.infradead.org/~tgr/libnl/doc/route.html#link_direct_lookup [2] https://bugzilla.redhat.com/show_bug.cgi?id=1158108#c18 [3] https://gerrit.ovirt.org/#/c/40571/4/lib/vdsm/netlink/link.py Change-Id: Iefa70103c7c0f218c89abbe5c8371b745064a13e Bug-Url: https://bugzilla.redhat.com/1158108 Signed-off-by: Petr Horáček <[email protected]> Reviewed-on: https://gerrit.ovirt.org/40812 Reviewed-by: Dan Kenigsberg <[email protected]> Continuous-Integration: Dan Kenigsberg <[email protected]> --- M lib/vdsm/netlink/link.py 1 file changed, 31 insertions(+), 21 deletions(-) Approvals: Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/40812 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefa70103c7c0f218c89abbe5c8371b745064a13e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: John Taylor <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
