Francesco Romani has posted comments on this change. Change subject: password: Prevent password logging and persisting ......................................................................
Patch Set 4: Code-Review+1 (1 comment) looks OK. Backporting will not be a walk in the park but should not be too hard. One minor issue with tests, I don't think is worth uploading a new version for that alone. https://gerrit.ovirt.org/#/c/40707/4/tests/passwordsTests.py File tests/passwordsTests.py: Line 29: class ProtectedPasswordTests(VdsmTestCase): Line 30: Line 31: def test_str(self): Line 32: p = ProtectedPassword("12345678") Line 33: self.assertFalse("12345678" in str(p)) minor: we have assertNotIn, also backported in testlib. Line 34: Line 35: def test_repr(self): Line 36: p = ProtectedPassword("12345678") Line 37: self.assertFalse("12345678" in repr(p)) -- To view, visit https://gerrit.ovirt.org/40707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc849ad8bdc1b1fd09884e18038427d96e66110f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
