Darshan N has posted comments on this change. Change subject: gluster: verbs to enable/disable snapshot scheduling. ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/40141/5/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 150: snap_scheduler > can't this be loaded as module than exec? Done Line 162: try: Line 163: fcntl.flock(f, fcntl.LOCK_EX | fcntl.LOCK_NB) Line 164: safeWrite(SNAP_SCHEDULER_FLAG, value) Line 165: fcntl.flock(f, fcntl.LOCK_UN) Line 166: except IOError: > you should log the error Done Line 167: os.close(f) Line 168: raise ge.GlusterSnapshotScheduleFlagUpdateFailedException( Line 169: err=["unable to get the lock"]) Line 170: except OSError as e: -- To view, visit https://gerrit.ovirt.org/40141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8f21593921bac18950a9ee42bb3972d278f7aa Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches