Ido Barkan has posted comments on this change. Change subject: net: simplify _find_nets_with_available_devices algorithm. ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/40541/4//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-05-14 10:44:01 +0300 Line 6: Line 7: net: simplify _find_nets_with_available_devices algorithm. Line 8: Line 9: Continue statements mad this algorithm a bit tricky to understand. > mad -> make Done Line 10: Line 11: Change-Id: I0c4972c16753e391bf2691a6739b088a4cbd05e7 https://gerrit.ovirt.org/#/c/40541/4/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 153: else: Line 154: available_nets[net] = attrs Line 155: Line 156: else: Line 157: # Bridge-only nics > since you touch the line, please fix the comment. It should read Done Line 158: available_nets[net] = attrs Line 159: Line 160: return available_nets Line 161: -- To view, visit https://gerrit.ovirt.org/40541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c4972c16753e391bf2691a6739b088a4cbd05e7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
