Hello Piotr Kliczewski, Timothy Asir, Bala.FA, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40949
to review the following change.
Change subject: gluster: List activate-on-create volume snapshot option
......................................................................
gluster: List activate-on-create volume snapshot option
Modified the verb glusterSnapshotConfigList to list
option activate-on-create as well.
Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73
Signed-off-by: Shubhendu Tripathi <shtri...@redhat.com>
Bug-URL: https://bugzilla.redhat.com/1216056
Reviewed-on: https://gerrit.ovirt.org/40416
Reviewed-by: Darshan N <dnara...@redhat.com>
Reviewed-by: Timothy Asir <tjeya...@redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Bala.FA <barum...@redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Reviewed-by: Dan Kenigsberg <dan...@redhat.com>
---
M tests/glusterSnapshotConfig.xml
M tests/glusterTestData.py
M vdsm/gluster/cli.py
M vdsm/rpc/vdsmapi-gluster-schema.json
4 files changed, 10 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/40949/1
diff --git a/tests/glusterSnapshotConfig.xml b/tests/glusterSnapshotConfig.xml
index d167fdc..698e806 100644
--- a/tests/glusterSnapshotConfig.xml
+++ b/tests/glusterSnapshotConfig.xml
@@ -8,6 +8,7 @@
<hardLimit>255</hardLimit>
<softLimit>91%</softLimit>
<autoDelete>disable</autoDelete>
+ <activateOnCreate>disable</activateOnCreate>
</systemConfig>
<volumeConfig>
<volume>
diff --git a/tests/glusterTestData.py b/tests/glusterTestData.py
index ad92ea2..0fdb7ef 100644
--- a/tests/glusterTestData.py
+++ b/tests/glusterTestData.py
@@ -1142,7 +1142,8 @@
'system': {
'snap-max-hard-limit': '255',
'auto-delete': 'disable',
- 'snap-max-soft-limit': '91%'
+ 'snap-max-soft-limit': '91%',
+ 'activate-on-create': 'disable'
}
}
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index e2462bb..8af5be0 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -1390,7 +1390,8 @@
"""
returns {'system':{'snap-max-hard-limit': 'hardlimit',
'snap-max-soft-limit': 'softLimit',
- 'auto-delete': 'enable/disable'},
+ 'auto-delete': 'enable/disable',
+ 'activate-on-create': 'enable/disable'},
'volume':{'name' :
{'snap-max-hard-limit: 'hardlimit'}
}
@@ -1403,6 +1404,8 @@
'snapConfig/systemConfig/softLimit').text
systemConfig['auto-delete'] = tree.find(
'snapConfig/systemConfig/autoDelete').text
+ systemConfig['activate-on-create'] = tree.find(
+ 'snapConfig/systemConfig/activateOnCreate').text
volumeConfig = {}
for el in tree.findall('snapConfig/volumeConfig/volume'):
diff --git a/vdsm/rpc/vdsmapi-gluster-schema.json
b/vdsm/rpc/vdsmapi-gluster-schema.json
index 7dc4fab..0aef3e6 100644
--- a/vdsm/rpc/vdsmapi-gluster-schema.json
+++ b/vdsm/rpc/vdsmapi-gluster-schema.json
@@ -1862,11 +1862,13 @@
#
# @auto-delete: Auto delete enabled/disabled
#
+# @activate-on-create: Auto activate enabled/disabled
+#
# @Since: 4.17.0
##
{'type': 'SystemSnapshotConfig',
'data': {'snap-max-hard-limit': 'str', 'snap-max-soft-limit': 'str',
- 'auto-delete': 'str'}}
+ 'auto-delete': 'str', 'activate-on-create': 'str'}}
##
#
--
To view, visit https://gerrit.ovirt.org/40949
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50ad0f482fc3d65e489c0a5c27212b84058c4c73
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
